[redundant_guards
]: catch is_empty
, starts_with
and ends_with
on slices and str
s
#11818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11807
Few things worth mentioning:
snippet
s is now done at callsite, instead of passing a span and doing it inemit_redundant_guards
. This is because we now need custom suggestion strings in certain places, like""
forstr::is_empty
.snippet
instead ofsnippet_with_applicability
. I don't think this really makes any difference forMaybeIncorrect
, though?&[u8; N]
, but that can be ugly so I decided to leave it out for nowchangelog: [
redundant_guards
]: catchstr::is_empty
,slice::is_empty
,slice::starts_with
andslice::ends_with