Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecated_semver]: Allow #[deprecated(since = "TBD")] #11850

Merged
merged 1 commit into from Nov 24, 2023

Conversation

Nilstrieb
Copy link
Member

"TBD" is allowed by rustdoc, saying that it will be deprecated in a future version. rustc will also not actually warn on it.
I found this while checking the rust-lang/rust with clippy.

changelog: [deprecated_semver]: allow using since = "TBD"

"TBD" is allowed by rustdoc, saying that it will be deprecated in a future version.
rustc will also not actually warn on it.
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 21, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dswij
Copy link
Member

dswij commented Nov 24, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

📌 Commit 43d8d51 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

⌛ Testing commit 43d8d51 with merge e075823...

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing e075823 to master...

@bors bors merged commit e075823 into rust-lang:master Nov 24, 2023
5 checks passed
@Nilstrieb Nilstrieb deleted the tbd branch November 24, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants