Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix box_default behaviour with empty vec![] coming from macro arg #11875

Merged
merged 1 commit into from Nov 26, 2023

Conversation

samueltardieu
Copy link
Contributor

Fix #11868

changelog: [box_default]: do not warn on Box::new(vec![]) if the vec![] comes from a macro argument

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 26, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Nov 26, 2023

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Nov 26, 2023

📌 Commit 23d5332 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 26, 2023

⌛ Testing commit 23d5332 with merge 2c56b4f...

@bors
Copy link
Collaborator

bors commented Nov 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 2c56b4f to master...

@bors bors merged commit 2c56b4f into rust-lang:master Nov 26, 2023
5 checks passed
@samueltardieu samueltardieu deleted the fix-11868 branch November 29, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive box_default inside macro
4 participants