needless_borrows_for_generic_args: Handle when field operand impl Drop #11900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, the lint had a false positive, namely when a reference was taken to a field when the field operand implements a custom Drop. The compiler will refuse to partially move a type that implements Drop, because that would put the operand in a weird state. See added regression test.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
Manishearth
approved these changes
Dec 2, 2023
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Dec 2, 2023
needless_borrows_for_generic_args: Handle when field operand impl Drop
Before this fix, the lint had a false positive, namely when a reference was taken to a field when the field operand implements a custom Drop. The compiler will refuse to partially move a type that implements Drop, because that would put the type in a weird state.
## False Positive Example (Fixed)
```rs
struct CustomDrop(String);
impl Drop for CustomDrop {
fn drop(&mut self) {}
}
fn check_str<P: AsRef<str>>(_to: P) {}
fn test() {
let owner = CustomDrop(String::default());
check_str(&owner.0); // Don't lint. `owner` can't be partially moved because it impl Drop
}
```
changelog: [`needless_borrows_for_generic_args`]: Handle when field operand impl Drop
|
💔 Test failed - checks-action_test |
|
Looks like the same error I'm seeing in my pull request. See #11904 (comment). |
|
@bors r=Manishearth |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Enselic
added a commit
to Enselic/cargo-public-api
that referenced
this pull request
Mar 5, 2024
My [fix](rust-lang/rust-clippy#11900) for the false positive has reached Rust 1.76 stable, so let's remove the annoying `allow`.
Enselic
added a commit
to Enselic/cargo-public-api
that referenced
this pull request
Mar 5, 2024
My [fix](rust-lang/rust-clippy#11900) for the false positive has reached Rust 1.76 stable, so let's remove the annoying `allow`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the lint had a false positive, namely when a reference was taken to a field when the field operand implements a custom Drop. The compiler will refuse to partially move a type that implements Drop, because that would put the type in a weird state.
False Positive Example (Fixed)
changelog: [
needless_borrows_for_generic_args]: Handle when field operand impl Drop