Do not consider async { (impl IntoFuture).await } as redundant
#11967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? @llogiq |
llogiq
approved these changes
Dec 25, 2023
| @@ -49,6 +50,9 @@ impl<'tcx> LateLintPass<'tcx> for RedundantAsyncBlock { | |||
| let Some(expr) = desugar_await(peel_blocks(body_expr)) && | |||
| // The await prefix must not come from a macro as its content could change in the future. | |||
| expr.span.eq_ctxt(body_expr.span) && | |||
| // The await prefix must implement Future, as implementing IntoFuture is not enough. | |||
| let Some(future_trait) = cx.tcx.lang_items().future_trait() && | |||
There was a problem hiding this comment.
This check means that the whole lint will be deactivated if lang items have no future.
That's totally OK, I just wanted to make that pun.
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
redundant_async_block]: do not trigger onIntoFutureinstancesFix #11959