Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11973: Don't escape " in '"' #12030

Conversation

torfsen
Copy link
Contributor

@torfsen torfsen commented Dec 27, 2023

Fixes #11973.

changelog: [`single_char_pattern`]: don't escape `"` in `'"'`

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 27, 2023
@llogiq
Copy link
Contributor

llogiq commented Jan 3, 2024

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 3, 2024

📌 Commit e5c9fb6 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 3, 2024

⌛ Testing commit e5c9fb6 with merge 17dcd0d...

@bors
Copy link
Collaborator

bors commented Jan 3, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 17dcd0d to master...

@bors bors merged commit 17dcd0d into rust-lang:master Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single_char_pattern produces incorrect suggestion for double quote character
4 participants