Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mitigations for incorrect node args #12041

Merged
merged 1 commit into from Dec 29, 2023

Conversation

compiler-errors
Copy link
Member

This change https://github.com/rust-lang/rust/pull/118420/files#r1419874371 adds a missing write_args to properly record node args for lang-item calls.

Thus, in the unnecessary_to_owned lint, this ensures that the call_generic_args extracted by get_callee_generic_args_and_args are always correct, and we can remove the mitigation for #9504 and #10021 since the root cause has been fixed.

I'm not sure if there is other now-unnecessary code that can be removed, but this is the one I found when investigating #11965 (comment).

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Dec 29, 2023

Thanks for noticing this. If there are other cases they at least aren't harmful to have. @bors r+

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

📌 Commit 3fceca2 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

⌛ Testing commit 3fceca2 with merge 8b22471...

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 8b22471 to master...

@bors bors merged commit 8b22471 into rust-lang:master Dec 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants