Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/issue#11243: allow 3-digit-grouped binary in non_octal_unix_permissions #12049

Merged
merged 4 commits into from Jan 8, 2024

Conversation

cocodery
Copy link
Contributor

fixes Issue#11243

Issue#11243 suggest lint non_octal_unix_permissions should not report binary format literal unix permissions as an error, and we think binary format is a good way to understand these permissions.

To solve this problem, we need to add check for binary literal, which is written in function check_binary_unix_permissions , only binary, 3 groups and each group length equals to 3 is a legal format.

changelog: [non_octal_unix_permissions]: Add check for binary format literal unix permissions like 0b111_111_111

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2023
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 30, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2023

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@cocodery
Copy link
Contributor Author

@rustbot ready

@cocodery
Copy link
Contributor Author

cocodery commented Jan 6, 2024

r? @Alexendoo

@rustbot rustbot assigned Alexendoo and unassigned giraffate Jan 6, 2024
@Alexendoo Alexendoo removed the has-merge-commits PR has merge commits, merge with caution. label Jan 7, 2024
@Alexendoo
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 8, 2024

📌 Commit a843996 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 8, 2024

⌛ Testing commit a843996 with merge 3b8323d...

@bors
Copy link
Collaborator

bors commented Jan 8, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 3b8323d to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Jan 8, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 3b8323d to master...

@bors bors merged commit 3b8323d into rust-lang:master Jan 8, 2024
5 checks passed
@cocodery cocodery deleted the fix/issue#11243 branch January 28, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Allow 3-digit-grouped binary in non_octal_unix_permissions
6 participants