New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/issue#11243: allow 3-digit-grouped binary in non_octal_unix_permissions #12049
Conversation
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
42edb84
to
79e70cc
Compare
@rustbot ready |
r? @Alexendoo |
Thank you! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes Issue#11243
Issue#11243 suggest lint
non_octal_unix_permissions
should not report binary format literal unix permissions as an error, and we think binary format is a good way to understand these permissions.To solve this problem, we need to add check for binary literal, which is written in function
check_binary_unix_permissions
, onlybinary, 3 groups and each group length equals to 3
is a legal format.changelog: [
non_octal_unix_permissions
]: Add check for binary format literal unix permissions like 0b111_111_111