Fixed FP in redundant_closure_call when closures are passed to macros
#12082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
m-rph
changed the title
redundant_closure_call when closures are passed to macrosredundant_closure_call when closures are passed to macros
24 tasks
dswij
reviewed
Jan 13, 2024
| $closure(1) | ||
| }; | ||
| } | ||
| m!(|x| println!("{x}")); |
There was a problem hiding this comment.
Can we also have a test case for || () cases as in https://github.com/rust-lang/rust-clippy/pull/12082/files#diff-ba9477a2653088e57270e74982b211e736a8f70a75f320dcba6a3d6ee37f3f75R179
There was a problem hiding this comment.
Something different to these?
rust-clippy/tests/ui/redundant_closure_call_fixable.rs
Lines 16 to 27 in 6558956
There are cases where the closure call is needed in some macros, this in particular occurs when the closure has parameters. To handle this case, we allow the lint when there are no parameters in the closure, or the closure is outside a macro invocation. fixes: rust-lang#11274, rust-lang#1553 changelog: FP: [`redundant_closure_call`] when closures with parameters are passed in macros.
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the closure call is needed in some macros, this in particular occurs when the closure has parameters. To handle this case, we allow the lint when there are no parameters in the closure, or the closure is outside a macro invocation.
fixes: #11274 #1553
changelog: FP: [
redundant_closure_call] when closures with parameters are passed in macros.