fix: incorrect suggestions generated by manual_retain lint

[yuxqiu]

fixes #10393, fixes #11457, fixes #12081

#10393: In the current implementation of manual_retain, if the argument to the closure is matched using tuple, they are all treated as the result of a call to map.into_iter().filter(<f>). However, such tuple pattern matching can also occur in many different containers that stores tuples internally. The correct approach is to apply different lint policies depending on whether the receiver of into_iter is a map or not.

#11457 and #12081: In the current implementation of manual_retain, if the argument to the closure is Binding, the closure will be used directly in the retain method, which will result in incorrect suggestion because the first argument to the retain closure may be of a different type. In addition, if the argument to the closure is Ref + Binding, the lint will simply remove the Ref part and use the Binding part as the argument to the new closure, which will lead to bad suggestion for the same reason. The correct approach is to detect each of these cases and apply lint suggestions conservatively.

changelog: [manual_retain] refactor and add check for various patterns

[rustbot]

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

[Alexendoo]

Thank you!

@bors r+

[bors]

📌 Commit 03b3a16 has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 03b3a16 with merge 8ccf6a6...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 8ccf6a6 to master...