Add .as_ref() to suggestion to remove .to_string() #12091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case of
.to_owned().split(…)
is treated specially in theunnecessary_to_owned
lint. Test cases check that it works both for slices and for strings, but they missed a corner case:x.to_string().split(…)
whenx
implementsAsRef<str>
but notDeref<Target = str>
. In this case, it is wrong to suggest to remove.to_string()
without adding.as_ref()
instead.Fix #12068
changelog: [
unnecessary_to_owned
]: suggest replacing.to_string()
by.as_ref()