Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest bool::then() and bool::then_some in const contexts #12108

Merged
merged 1 commit into from Jan 7, 2024

Conversation

samueltardieu
Copy link
Contributor

Fix #12103

changelog: [if_then_some_else_none]: Do not trigger in const contexts

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2024

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 7, 2024
@xFrednet
Copy link
Member

xFrednet commented Jan 7, 2024

LGTM, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

📌 Commit 5b7a0de has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

⌛ Testing commit 5b7a0de with merge adc5bc9...

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing adc5bc9 to master...

@bors bors merged commit adc5bc9 into rust-lang:master Jan 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if_then_some_else_none recommends bool::then in const functions
4 participants