Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "calls" inside the closure as well in map_clone lint #12109

Merged
merged 2 commits into from Jan 7, 2024

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #12104.

I just realized that I didn't handle the case where the clone method was made as a call and not a method call.

r? @llogiq

changelog: Handle "calls" inside the closure as well in map_clone lint

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 7, 2024
@GuillaumeGomez
Copy link
Member Author

Fixed dogfood (one day I'll not forget...).

@llogiq
Copy link
Contributor

llogiq commented Jan 7, 2024

Makes sense. Thanks again.

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

📌 Commit f66e940 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

⌛ Testing commit f66e940 with merge f37e7f3...

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing f37e7f3 to master...

@bors bors merged commit f37e7f3 into rust-lang:master Jan 7, 2024
5 checks passed
@GuillaumeGomez GuillaumeGomez deleted the map-clone-call branch January 7, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants