Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

['arc_with_non_send_sync`] documentation edits #12114

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

talagrand
Copy link
Contributor

@talagrand talagrand commented Jan 9, 2024

Arc's documentation uses the term "thread"; aligning to that terminology. Fix casing of "Rc".

changelog: None

Arc's documentation uses the term "thread", aligning to that terminology. Fix typo in "Rc".
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 9, 2024
@talagrand
Copy link
Contributor Author

Also, unrelated to this doc update, but kudos for this lint. It found a number of soundness issues in our codebase when we upgraded (crossing an ABI boundary meant we didn't get Rust's usual typesystem-level enforcement on smuggling non-Send types across threads).

@Jarcho
Copy link
Contributor

Jarcho commented Jan 15, 2024

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

📌 Commit c2d071c has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

⌛ Testing commit c2d071c with merge 93ee420...

bors added a commit that referenced this pull request Jan 15, 2024
['arc_with_non_send_sync`] documentation edits

Arc's documentation uses the term "thread"; aligning to that terminology. Fix casing of "Rc".
@bors
Copy link
Collaborator

bors commented Jan 15, 2024

💔 Test failed - checks-action_test

@Jarcho
Copy link
Contributor

Jarcho commented Jan 15, 2024

@bors retry

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

⌛ Testing commit c2d071c with merge 37b8ae7...

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 37b8ae7 to master...

@bors bors merged commit 37b8ae7 into rust-lang:master Jan 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants