Fix error warning span for issue12045

[cocodery]

fixes Issue#12045

In issue#12045, unexpected warning span occurs on attribute #[derive(typed_builder::TypedBuilder)], actually the warning should underline _lifetime.

In the source code we can find that the original intend is to warning on ident.span, but in this case, stmt.span is unequal with ident.span. So, fix the nit here is fine.

Besides, ident.span have an accurate range than stmt.span.

changelog: [no_effect_underscore_binding]: correct warning span

[rustbot]

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

[cocodery]

r? @xFrednet

[xFrednet]

Looks good to me, I love that the test code looks familiar ^^

Thank you for the update :D

@bors r+

[bors]

📌 Commit 7c389ac has been approved by xFrednet

It is now in the queue for this repository.

[xFrednet]

@bors r-

[bors]

⌛ Testing commit 7c389ac with merge 5e0939f...

[xFrednet]

Wait, I like the change to the emission span, but I believe that it will not resolve the linked issue. The problem is, that the lint doesn't notice that the thing it lints, is inside derived code. The lint level is determined at the emission node, not in the span, so this change will still leave the FP. This is a nice update either way, but to solve this issue you probably need to add a check with any_parent_is_automatically_derived and also add a test with derived code.

[bors]

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 5e0939f (5e0939f259821575997ac57f3287fc87a7ead452)

[cocodery]

I have already fixed the addition question locally by add !any_parent_is_automatically_derived(cx.tcx, local.hir_id) to prevent derive expansion code.

But sorry that the test seems not easy to add. I have figured out the issue is generate by derive node expansion, through marco parse_macro_input I think. So writiing some proc_macro_derive attribute uses marco parse_macro_input and use them in struct field maybe fine.

If directly adding related issue code with typed-builder = "0.18" into toml file, and copy codes to test file, a can't find crate error emitted I havn't figured out. Or maybe [lib] proc-macro = true [dependencies.proc-macro2] version = "1" kind of things should be added into toml file, but too complex. Both will change toml file, I think maybe it's not suitable to modify toml file.

Is is available to clarity this issue in test file comment instead of a test code? :) @xFrednet

[xFrednet]

Sorry for the late response the end of my winter semester is killing me 😅

I have already fixed the addition question locally by add !any_parent_is_automatically_derived(cx.tcx, local.hir_id) to prevent derive expansion code.

I don't see this change in this PR, have you done that part in a previous one?

Regarding testing, this is sadly complicated for these kinds of macros. We have util for other macros, but apparently not derives. I checked the test for another lint and that one doesn't have tests for the derive case, so I think it's safe to close the issue if the any_parent_is_automatically_derived check is present. :)

[cocodery]

hahhaha, no worries, it's fine.

I fixed in one local commit, I haven't push yet beacuse of the complexity of test and was waiting your reply last several days.

[xFrednet]

Thanks, looks good to me :)

@bors r+

[bors]

📌 Commit 73d7ce6 has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 73d7ce6 with merge 989ce17...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 989ce17 to master...