Don't emit derive_partial_eq_without_eq lint if the type has the non_exhaustive attribute
#12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
llogiq
reviewed
Jan 20, 2024
clippy_lints/src/derive.rs
Outdated
| @@ -442,13 +442,25 @@ impl<'tcx> Visitor<'tcx> for UnsafeVisitor<'_, 'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| fn has_non_exhaustive_attr(cx: &LateContext<'_>, adt: AdtDef<'_>) -> bool { | |||
There was a problem hiding this comment.
This function should probably be in clippy_utils, it looks like there may be other lints in the future where it might be handy.
There was a problem hiding this comment.
Moving it then. 👍
GuillaumeGomez
force-pushed
the
non-exhaustive
branch
from
f7c7191
to
fd6e752
Compare
|
Moved the function to |
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Jan 20, 2024
Don't emit `derive_partial_eq_without_eq` lint if the type has the `non_exhaustive` attribute Part of #9063. If a type has a field/variant with the `#[non_exhaustive]` attribute or the type itself has it, then do no emit the `derive_partial_eq_without_eq` lint. changelog: Don't emit `derive_partial_eq_without_eq` lint if the type has the `non_exhaustive` attribute
|
💔 Test failed - checks-action_test |
|
Ah, that's a new failure. XD |
|
@bors retry (want to re-trigger bors, as I just synced the queue, and this showed up as approved again, but bors didn't start) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9063.
If a type has a field/variant with the
#[non_exhaustive]attribute or the type itself has it, then do no emit thederive_partial_eq_without_eqlint.changelog: Don't emit
derive_partial_eq_without_eqlint if the type has thenon_exhaustiveattribute