Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FP on [semicolon_if_nothing_returned] #12167

Merged
merged 2 commits into from Jan 18, 2024
Merged

Conversation

J-ZhengLi
Copy link
Member

fixes: #12123


changelog: fix FP on [semicolon_if_nothing_returned] which suggesting adding semicolon after attr macro

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2024

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 18, 2024
@Alexendoo
Copy link
Member

Thanks! Interesting one that the #[rustfmt::skip]s are needed to reproduce the issue

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 18, 2024

📌 Commit 0e961cd has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 18, 2024

⌛ Testing commit 0e961cd with merge 4b3a9c0...

@bors
Copy link
Collaborator

bors commented Jan 18, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4b3a9c0 to master...

@bors bors merged commit 4b3a9c0 into rust-lang:master Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semicolon_if_nothing_returned on an attribute macro
4 participants