Don't warn about modulo arithmetic when comparing to zero #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #12144) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thank you, r=me after a rebase. |
mdm
force-pushed
the
modulo-arithmetic-comparison-to-zero
branch
2 times, most recently
from
db99c3e
to
7078f18
Compare
|
@llogiq I rebased. Is there anything else you need me to do? Sorry if I missed something obvious. I'm a new contributor. |
|
☔ The latest upstream changes (presumably #12179) made this pull request unmergeable. Please resolve the merge conflicts. |
mdm
force-pushed
the
modulo-arithmetic-comparison-to-zero
branch
from
7078f18
to
7af81b7
Compare
Add lint configuration for `modulo_arithmetic` Collect meta-data
mdm
force-pushed
the
modulo-arithmetic-comparison-to-zero
branch
from
7af81b7
to
e456c28
Compare
|
Thank you! Sorry for the delay. @bors r+ |
bors
added a commit
that referenced
this pull request
Jan 27, 2024
…ogiq Don't warn about modulo arithmetic when comparing to zero closes #12006 By default, don't warn about modulo arithmetic when comparing to zero. This behavior is configurable via `clippy.toml`. See discussion [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.E2.9C.94.20Is.20issue.20.2312006.20worth.20implementing.3F) changelog: [`modulo_arithmetic`]: By default don't lint when comparing the result of a modulo operation to zero.
|
💔 Test failed - checks-action_test |
|
@bors retry Seems the Mac runner is acting up again |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12006
By default, don't warn about modulo arithmetic when comparing to zero. This behavior is configurable via
clippy.toml.See discussion on Zulip
changelog: [
modulo_arithmetic]: By default don't lint when comparing the result of a modulo operation to zero.