Take lifetime extension into account in ref_as_ptr
#12260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry for the delay, I was quite sick the last two weeks and am still recovering. r=me after a rebase. |
|
@bors r=llogiq Take the time you need to recover. |
bors
added a commit
that referenced
this pull request
Feb 24, 2024
Take lifetime extension into account in `ref_as_ptr` fixes #12255 This should be merged upstream as well. Changing `let x = &temp as *const _` into `let x = from_ref(&temp)` is UB. changelog: `ref_as_ptr`: Take lifetime extension into account
|
💔 Test failed - checks-action_test |
|
@bors retry |
Jarcho
added
the
beta-nominated
bors
added a commit
that referenced
this pull request
Feb 24, 2024
Take lifetime extension into account in `ref_as_ptr` fixes #12255 This should be merged upstream as well. Changing `let x = &temp as *const _` into `let x = from_ref(&temp)` is UB. changelog: `ref_as_ptr`: Take lifetime extension into account
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Third time's the charm. 😄 |
|
This lint is not in |
flip1995
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12255
This should be merged upstream as well. Changing
let x = &temp as *const _intolet x = from_ref(&temp)is UB.changelog:
ref_as_ptr: Take lifetime extension into account