new lint `legacy_numeric_constants` #12312

pitaj · 2024-02-18T18:16:15Z

Rework of #10997

uses diagnostic items
does not lint imports of the float modules (use std::f32)
does not lint usage of float constants that look like f32::MIN

I chose to make the float changes because the following pattern is actually pretty useful

use std::f32;
let omega = freq * 2 * f32::consts::PI;

and the float modules are not TBD-deprecated like the integer modules.

Closes #10995

changelog: New lint [legacy_numeric_constants]
#12312

rustbot · 2024-02-18T18:16:21Z

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

pitaj · 2024-02-18T18:17:17Z

r? xFrednet since they reviewed the last one. Also, CC @Centri3

bors · 2024-02-19T09:37:27Z

☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.

…nstants, r=Nilstrieb Add diagnostic items for legacy numeric constants For rust-lang/rust-clippy#12312

Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb Add diagnostic items for legacy numeric constants For rust-lang/rust-clippy#12312

clippy_lints/src/legacy_numeric_constants.rs

…nstants, r=Nilstrieb diagnostic items for legacy numeric modules For rust-lang/rust-clippy#12312 Missed these in rust-lang#121272 r? `@Nilstrieb`

Rollup merge of rust-lang#121361 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb diagnostic items for legacy numeric modules For rust-lang/rust-clippy#12312 Missed these in rust-lang#121272 r? `@Nilstrieb`

xFrednet · 2024-02-25T21:25:03Z

Hey, thank you for picking this up. This is on my todo list for next week, you should have a review by Friday, the latest. :)

…tants, r=Nilstrieb syms for legacy numeric constants diag items Missed these in rust-lang#121272 and rust-lang#121361, woops. For rust-lang/rust-clippy#12312 r? `@Nilstrieb`

…Nilstrieb syms for legacy numeric constants diag items Missed these in #121272 and #121361, woops. For rust-lang/rust-clippy#12312 r? `@Nilstrieb`

xFrednet

The implementation looks good to me. I have two suggestions, where I would like to hear your thoughts about it. Once they've been discussed, this should be good to go.

And also thank you for your patience! The next review will be quicker :D

tests/ui/legacy_numeric_constants.stderr

tests/ui/legacy_numeric_constants_unfixable.stderr

pitaj · 2024-03-04T01:18:16Z

Thanks for taking a look. It seems like the next toolchain update should be on the 7th, which should include all the necessary diagnostic items.

I've made the changes you suggested, but wait to merge until I modify this to use the diag items.

pitaj · 2024-03-10T06:40:08Z

Welp, in working on the implementation I discovered that the diag items were still incomplete. So I guess we'll wait another two weeks 🙃

…nstants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? `@Nilstrieb` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!

…nstants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? ``@Nilstrieb`` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!

…nstants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? ```@Nilstrieb``` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!

xFrednet · 2024-03-10T10:45:18Z

Okay, good to know :D I'll mark this as waiting for you. Once the next update is ready, you can push the update, and it should show up in my inbox again. Otherwise, you can also always ping me :D

@rustbot author

Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? ```@Nilstrieb``` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!

bors · 2024-03-20T00:02:58Z

☔ The latest upstream changes (presumably #12511) made this pull request unmergeable. Please resolve the merge conflicts.

pitaj · 2024-03-21T23:21:06Z

@rustbot ready

xFrednet

This version looks good to me. I love how almost 1/3 of the implementation lines are just diagnostic symbols :D

I have a tiny nit in the tests, and then we can merge this. You can r=me after the next update.

@bors delegate+

tests/ui/legacy_numeric_constants.rs

tests/ui/legacy_numeric_constants_unfixable.rs

xFrednet · 2024-03-24T10:05:35Z

Looks like bors commands still don't work in reviews... Let's try this again:

@bors delegate+

bors · 2024-03-24T10:05:38Z

✌️ @pitaj, you can now approve this pull request!

If @xFrednet told you to "r=me" after making some further change, please make that change, then do @bors r=xFrednet

xFrednet · 2024-03-24T10:49:20Z

Actually, let's not r+ it yet. I just remembered that @Manishearth suggested in the last meeting, that we discuss/notify others about new lints first to see if someone has comments on it. So let's keep this open for a week, to see if others have any thoughts on it. I'll write something for Zulip :)

Zulip: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/New.20.60legacy_numeric_constants.60.20lint.20rust-clippy.2312312/near/429186612

clippy_lints/src/legacy_numeric_constants.rs

xFrednet · 2024-03-30T17:49:28Z

It has been a week and all comments have been positive, so I'm merging this now. Thank you for the new lint :D

@bors r+

@rustbot label -S-final-comment-period

bors · 2024-03-30T17:49:31Z

📌 Commit f2e91ab has been approved by xFrednet

It is now in the queue for this repository.

bors · 2024-03-30T17:50:38Z

⌛ Testing commit f2e91ab with merge cebf879...

bors · 2024-03-30T17:58:40Z

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing cebf879 to master...

rustbot assigned dswij Feb 18, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 18, 2024

rustbot assigned xFrednet and unassigned dswij Feb 18, 2024

pitaj force-pushed the legacy_numeric_constants branch 4 times, most recently from 123be52 to f605385 Compare February 18, 2024 18:43

pitaj mentioned this pull request Feb 18, 2024

Add diagnostic items for legacy numeric constants rust-lang/rust#121272

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 19, 2024

Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_co…

07f0d04

…nstants, r=Nilstrieb Add diagnostic items for legacy numeric constants For rust-lang/rust-clippy#12312

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 19, 2024

Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_co…

c2cc066

…nstants, r=Nilstrieb Add diagnostic items for legacy numeric constants For rust-lang/rust-clippy#12312

pitaj mentioned this pull request Feb 20, 2024

diagnostic items for legacy numeric modules rust-lang/rust#121361

Merged

est31 reviewed Feb 21, 2024

View reviewed changes

clippy_lints/src/legacy_numeric_constants.rs Show resolved Hide resolved

pitaj mentioned this pull request Feb 27, 2024

syms for legacy numeric constants diag items rust-lang/rust#121667

Merged

xFrednet reviewed Mar 1, 2024

View reviewed changes

tests/ui/legacy_numeric_constants.stderr Outdated Show resolved Hide resolved

tests/ui/legacy_numeric_constants_unfixable.stderr Outdated Show resolved Hide resolved

pitaj force-pushed the legacy_numeric_constants branch from f605385 to c5edb8e Compare March 4, 2024 01:10

pitaj mentioned this pull request Mar 10, 2024

Fix legacy numeric constant diag items rust-lang/rust#122271

Merged

rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 10, 2024

pitaj force-pushed the legacy_numeric_constants branch 2 times, most recently from c9b5198 to 73ad96f Compare March 21, 2024 23:05

new lint legacy_numeric_constants

0c392d9

pitaj force-pushed the legacy_numeric_constants branch from 73ad96f to 0c392d9 Compare March 21, 2024 23:10

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 21, 2024

xFrednet approved these changes Mar 24, 2024

View reviewed changes

tests/ui/legacy_numeric_constants.rs Outdated Show resolved Hide resolved

tests/ui/legacy_numeric_constants_unfixable.rs Outdated Show resolved Hide resolved

xFrednet added S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 24, 2024

Alexendoo reviewed Mar 24, 2024

View reviewed changes

clippy_lints/src/legacy_numeric_constants.rs Outdated Show resolved Hide resolved

match syms, remove lint_reasons

f2e91ab

xFrednet approved these changes Mar 30, 2024

View reviewed changes

rustbot removed the S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) label Mar 30, 2024

bors merged commit cebf879 into rust-lang:master Mar 30, 2024
8 checks passed

bors mentioned this pull request Mar 30, 2024

Add lint which checks that duration conversion aren't losing precision #12539

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new lint `legacy_numeric_constants` #12312

new lint `legacy_numeric_constants` #12312

pitaj commented Feb 18, 2024 •

edited by xFrednet

rustbot commented Feb 18, 2024

pitaj commented Feb 18, 2024

bors commented Feb 19, 2024

xFrednet commented Feb 25, 2024

xFrednet left a comment

pitaj commented Mar 4, 2024

pitaj commented Mar 10, 2024

xFrednet commented Mar 10, 2024

bors commented Mar 20, 2024

pitaj commented Mar 21, 2024

xFrednet left a comment

xFrednet commented Mar 24, 2024

bors commented Mar 24, 2024 •

edited by xFrednet

xFrednet commented Mar 24, 2024 •

edited

xFrednet commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

new lint legacy_numeric_constants #12312

new lint legacy_numeric_constants #12312

Conversation

pitaj commented Feb 18, 2024 • edited by xFrednet

rustbot commented Feb 18, 2024

pitaj commented Feb 18, 2024

bors commented Feb 19, 2024

xFrednet commented Feb 25, 2024

xFrednet left a comment

Choose a reason for hiding this comment

pitaj commented Mar 4, 2024

pitaj commented Mar 10, 2024

xFrednet commented Mar 10, 2024

bors commented Mar 20, 2024

pitaj commented Mar 21, 2024

xFrednet left a comment

Choose a reason for hiding this comment

xFrednet commented Mar 24, 2024

bors commented Mar 24, 2024 • edited by xFrednet

xFrednet commented Mar 24, 2024 • edited

xFrednet commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

new lint `legacy_numeric_constants` #12312

new lint `legacy_numeric_constants` #12312

pitaj commented Feb 18, 2024 •

edited by xFrednet

bors commented Mar 24, 2024 •

edited by xFrednet

xFrednet commented Mar 24, 2024 •

edited