Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be careful with expressions with attributes #12322

Merged
merged 1 commit into from Feb 24, 2024

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Feb 20, 2024

Fix #9949.

changelog: [unused_unit]: skip expressions with attributes

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 20, 2024
@llogiq
Copy link
Contributor

llogiq commented Feb 24, 2024

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 24, 2024

📌 Commit cd45d5a has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 24, 2024

⌛ Testing commit cd45d5a with merge 6405469...

@bors
Copy link
Collaborator

bors commented Feb 24, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 6405469 to master...

@bors bors merged commit 6405469 into rust-lang:master Feb 24, 2024
5 checks passed
@sanxiyn sanxiyn deleted the expression-with-attribute branch February 26, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused_unit will remove items led by attributes
4 participants