Add new unnecessary_get_then_check lint
#12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
add-unnecessary_get_then_check
branch
3 times, most recently
from
9f3e45a
to
b3dcee0
Compare
|
Finally fixed doc examples and dogfood. ^^' Pretty nice to see that the lint already caught some cases in clippy source code. :) |
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Feb 24, 2024
… r=llogiq Add new `unnecessary_get_then_check` lint No issue linked to this as far as I can see. It's a lint I discovered that could be added when I worked on another lint. r? `@llogiq` changelog: Add new `unnecessary_get_then_check` lint
|
💔 Test failed - checks-action_test |
|
Rebasing just in case... |
GuillaumeGomez
force-pushed
the
add-unnecessary_get_then_check
branch
from
b3dcee0
to
5e2707d
Compare
|
Rebased! |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue linked to this as far as I can see. It's a lint I discovered that could be added when I worked on another lint.
r? @llogiq
changelog: Add new
unnecessary_get_then_checklint