Add new mixed_attributes_style lint
#12354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
mixed_attributes_style
branch
from
a1319bf
to
6edc3f9
Compare
|
Note for future self: run |
GuillaumeGomez
force-pushed
the
mixed_attributes_style
branch
from
6edc3f9
to
1631ee3
Compare
|
And also dogfood... |
|
Ci passed. \o/ |
llogiq
approved these changes
Feb 26, 2024
| } | ||
|
|
||
| #[allow(unused)] | ||
| #[allow(unused)] |
There was a problem hiding this comment.
Attribute duplication might be worth another lint.
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Feb 26, 2024
Add new `mixed_attributes_style` lint Add a new lint to detect cases where both inner and outer attributes are used on a same item. r? `@llogiq` changelog: Add new `mixed_attributes_style` lint
|
💔 Test failed - checks-action_test |
|
Seems completely unrelated. Retry? :3 |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 27, 2024
Add new `mixed_attributes_style` lint Add a new lint to detect cases where both inner and outer attributes are used on a same item. r? `@llogiq` ---- changelog: Add new [`mixed_attributes_style`] lint
|
💔 Test failed - checks-action_test |
GuillaumeGomez
force-pushed
the
mixed_attributes_style
branch
from
1631ee3
to
4a228ba
Compare
|
Rebased and allowed this lint in |
GuillaumeGomez
force-pushed
the
mixed_attributes_style
branch
from
4a228ba
to
f301386
Compare
|
Rebased again. |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new lint to detect cases where both inner and outer attributes are used on a same item.
r? @llogiq
changelog: Add new [
mixed_attributes_style] lint