Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assigning_clones MSRV check more precise #12516

Merged
merged 2 commits into from Mar 20, 2024

Conversation

humannum14916
Copy link
Contributor

Continuation of #12511

clone_into is the only suggestion subject to the 1.63 MSRV requirement, and the lint should still emit other suggestions regardless of the MSRV.

changelog: [assigning_clones]: only apply MSRV check to clone_into suggestions.

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 20, 2024
@Alexendoo
Copy link
Member

Thanks again! @bors r+

@bors
Copy link
Collaborator

bors commented Mar 20, 2024

📌 Commit db7c9fe has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 20, 2024

⌛ Testing commit db7c9fe with merge 5b7efe8...

@bors
Copy link
Collaborator

bors commented Mar 20, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 5b7efe8 to master...

@bors bors merged commit 5b7efe8 into rust-lang:master Mar 20, 2024
5 checks passed
@Kobzol
Copy link
Contributor

Kobzol commented Mar 20, 2024

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants