Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version for incompatible_msrv #12522

Merged
merged 1 commit into from Mar 22, 2024
Merged

Correct version for incompatible_msrv #12522

merged 1 commit into from Mar 22, 2024

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 21, 2024

Unsure what happened here

Probably what caused rust-lang/blog.rust-lang.org#1277

changelog: none

Unsure what happened here

Probably what caused rust-lang/blog.rust-lang.org#1277
@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 21, 2024
@epage
Copy link

epage commented Mar 21, 2024

Probably what caused rust-lang/blog.rust-lang.org#1277

I explicitly checked the changelog but the entry was generated after I suggested it go into the blog post. In Cargo, we generate the beta changelog entry when branched from master which would have made it available and this would have been caught.

@xFrednet
Copy link
Member

Unsure what happened here

This was the correct version when the lint PR was created and a great example, why nightly lints would be awesome. I usually update the version attributes when I write the changelog for that version. But this sadly creates a desync. I'd correct this version, when I write the changelog for 1.78.

@Mark-Simulacrum
Copy link
Member

FWIW, rust-lang/rust has a magic string and script that we bump version numbers for during nightly -> beta promotion (when the version number becomes fixed). See https://github.com/rust-lang/rust/blob/master/src/tools/replace-version-placeholder/src/main.rs for the script.

If clippy wanted to, you could likely rely on us running that script and picking up the version numbers in a subsequent subtree sync?

@xFrednet
Copy link
Member

That's something I haven't considered before. Thank you for the idea, I'll investigate it, when I find the time :D

@xFrednet
Copy link
Member

xFrednet commented Mar 22, 2024

Either way, I think we can merge this for now :). Thank you for the update!

r? @xFrednet

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 22, 2024

📌 Commit 87b9352 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 22, 2024

⌛ Testing commit 87b9352 with merge fc053c3...

@bors
Copy link
Collaborator

bors commented Mar 22, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing fc053c3 to master...

@bors bors merged commit fc053c3 into master Mar 22, 2024
6 checks passed
@y21 y21 deleted the Manishearth-patch-1 branch March 25, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants