Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual_assert: do not add extra semicolon #12536

Merged
merged 2 commits into from Mar 25, 2024

Conversation

samueltardieu
Copy link
Contributor

Fixes #12505

changelog: [manual_assert]: do not add extra semicolon to suggestion

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 23, 2024
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 25, 2024

📌 Commit c137c78 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 25, 2024

⌛ Testing commit c137c78 with merge b1b7352...

@bors
Copy link
Collaborator

bors commented Mar 25, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing b1b7352 to master...

@bors bors merged commit b1b7352 into rust-lang:master Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_assert must not duplicate ending ";" inside impl
4 participants