[module_name_repetition] Recognize common prepositions
#12573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ARandomDev99
suggested changes
Mar 28, 2024
tests/ui-toml/item_name_repetitions/allowed_prepositions/item_name_repetitions.rs
Outdated
Show resolved
Hide resolved
J-ZhengLi
reviewed
Mar 28, 2024
|
'Prefixes' would be a better name than 'prepositions'. |
modelflat
force-pushed
the
recognize-common-prepositions-in-module-name-repetitions
branch
2 times, most recently
from
06a1e67
to
c97bee6
Compare
|
@Jarcho thanks for the suggestions! I agree with both - implemented. |
|
Thank you. @bors r+ |
bors
added a commit
that referenced
this pull request
Apr 4, 2024
…ule-name-repetitions, r=Jarcho [`module_name_repetition`] Recognize common prepositions Fixes #12544 changelog: [`module_name_repetition`]: don't report an item name if it consists only of a prefix from `allowed-prefixes` list and a module name (e.g. `AsFoo` in module `foo`). Prefixes allowed by default: [`to`, `from`, `into`, `as`, `try_into`, `try_from`]
|
💔 Test failed - checks-action_test |
…ffix Fixes rust-lang#12544. - don't report an item name if it consists only of a prefix from `allowed-prefixes` list and a module name (e.g. `AsFoo` in module `foo`). - configured by `allowed-prefixes` config entry - prefixes allowed by default: [`to`, `from`, `into`, `as`, `try_into`, `try_from`] - update docs
modelflat
force-pushed
the
recognize-common-prepositions-in-module-name-repetitions
branch
from
ba25e42
to
3705073
Compare
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12544
changelog: [
module_name_repetition]: don't report an item name if it consists only of a prefix fromallowed-prefixeslist and a module name (e.g.AsFooin modulefoo). Prefixes allowed by default: [to,from,into,as,try_into,try_from]