type certainty: clear DefId when an expression's type changes to non-adt

[y21]

Fixes #12585

The root cause of the ICE in the linked issue was in the expression one.x, in the array literal.

The type of one is the One struct: an adt with a DefId, so its certainty is Certain(def_id_of_one). However, the field access .x can then change the type (to i32 here) and that should update that DefId accordingly. It does do that correctly when one.x would be another adt with a DefId:

rust-clippy/clippy_utils/src/ty/type_certainty/mod.rs

Lines 90 to 91 in 97ba291

	if let Some(def_id) = adt_def_id(expr_ty) {
	certainty.with_def_id(def_id)

but when it isn't an adt and there is no def id (which is the case in the linked issue: one.x is an i32), it keeps the DefId of One, even though that's the wrong type (which would then lead to a contradiction later when joining Certaintys):

rust-clippy/clippy_utils/src/ty/type_certainty/mod.rs

Lines 92 to 93 in 97ba291

	} else {
	certainty

In particular, in the linked issue, from_array([one.x, two.x]) would try to join the Certainty of the two array elements, which should have been [Certain(None), Certain(None)], because i32s have no DefId, but instead it was [Certain(One), Certain(Two)], because the DefId wasn't cleared from when it was visiting one and two. This is the "contradiction" that could be seen in the ICE message

... so this changes it to clear the DefId when it isn't an adt.

cc @smoelius you implemented this initially in #11135, does this change make sense to you?

changelog: none

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[smoelius]

cc @smoelius you implemented this initially in #11135, does this change make sense to you?

It does. Thanks very much for fixing this, @y21.

[Jarcho]

Thank you. @bors r+

[bors]

📌 Commit 9f5d31e has been approved by Jarcho

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9f5d31e with merge 8253040...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 8253040 to master...