Elide unit variables linted by let_unit and use () directly instead
#12603
Conversation
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
|
🤔 would it be worth it to continue linting but suggest replacing every use of the binding with |
|
I think we could do that. It could look be a bit silly buuuuuuut why not? :D |
m-rph
changed the title
let_unit bindings that are usedlet_unit and use () directly instead
Situation: `let_unit` lints when an expression binds a unit (`()`) to a variable. In some cases this binding may be passed down to another function. Currently, the lint removes the binding without considering usage. Change: All usages of the elided variable are now replaced with `()`. fixes: rust-lang#12594
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Situation:
let_unitlints when an expression binds a unit (()) to a variable. In some cases this binding may be passed down to another function. Currently, the lint removes the binding without considering usage.fixes: #12594
changelog: Suggestion Fix [
let_unit]. Clippy will remove unit bindings and replace all their instances in the body with().