Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword arc_with_non_send_sync note and help messages #12609

Merged
merged 1 commit into from Apr 4, 2024

Conversation

Alexendoo
Copy link
Member

Addresses #12608 (comment)

Makes the note more concise and reframes the Rc suggestion around whether it crosses threads currently due to a manual Send/Sync impl or may do in the future

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 1, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Apr 4, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

📌 Commit 9d4a368 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

⌛ Testing commit 9d4a368 with merge a73e751...

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing a73e751 to master...

@bors bors merged commit a73e751 into rust-lang:master Apr 4, 2024
5 checks passed
@Alexendoo Alexendoo deleted the arc-with-non-send-sync-message branch April 5, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants