Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #12612 #12647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add regression test for #12612 #12647

wants to merge 1 commit into from

Conversation

GuillaumeGomez
Copy link
Member

Fixes #12612.
Fixes #12560.

Seems like this bug was fixed in #12535.

changelog: Add regression test for #12612 and #12560.

@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 8, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 8, 2024
Open
@Jarcho
Copy link
Contributor

Jarcho commented Apr 12, 2024

Both of those issues are only half fixed. map_clone still doesn't properly check the types involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong suggestion for clippy::map_clone Errorneous suggestion with map + Arc::clone of custom expression
3 participants
@GuillaumeGomez @rustbot @Jarcho