feat: Quick Fix for bare URLs
#12836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
hamirmahal
commented
May 23, 2024
J-ZhengLi
reviewed
May 23, 2024
There was a problem hiding this comment.
I wanted to try this out in an IDE with rust-analyzer but wasn't able to do so.
not sure if there's a way 🤔, but you can put your test code in tests/ui/doc/doc-fixable.rs, then run TESTNAME='doc-fixable' cargo uibless to "try it out".
y21
reviewed
May 23, 2024
|
I'm surprised that this didn't have to touch any tests and the checks are still passing. We should definitely have a test for this like @J-ZhengLi said :) |
y21
approved these changes
May 24, 2024
hamirmahal
force-pushed
the
feat/quick-fix-for-bare-urls
branch
from
2d45949
to
6f3e830
Compare
hamirmahal
force-pushed
the
feat/quick-fix-for-bare-urls
branch
from
6f3e830
to
17cc0a3
Compare
Sure! I just squashed them after rebasing against the main branch. |
|
Thanks! @bors r+ |
|
You're welcome! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12835.
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: [
clippy::doc_markdown]:Quick Fixforbare URLs