-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parentheses to [let_and_return
]'s suggestion
#12842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, very nice improvement
@@ -1038,14 +1040,8 @@ fn report<'tcx>( | |||
); | |||
}, | |||
State::ExplicitDeref { mutability } => { | |||
if matches!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool to see that this function is useful in other lints too
thanks! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
closes: #12801
changelog: suggest adding parentheses when linting [
let_and_return
] and [needless_return
]