-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: let non_canonical_impls skip proc marco #12857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
May 26, 2024
y21
reviewed
May 26, 2024
WeiTheShinobi
force-pushed
the
non_canonical_impls
branch
from
May 30, 2024 15:24
1fe6819
to
64be449
Compare
y21
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go with this one fixed
WeiTheShinobi
force-pushed
the
non_canonical_impls
branch
2 times, most recently
from
May 30, 2024 15:39
c88db48
to
38f173f
Compare
WeiTheShinobi
force-pushed
the
non_canonical_impls
branch
from
May 30, 2024 15:40
38f173f
to
1038927
Compare
y21
approved these changes
May 30, 2024
Looks good, thanks! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12788
Although the issue only mentions
NON_CANONICAL_CLONE_IMPL
, this fix will also affectNON_CANONICAL_PARTIAL_ORD_IMPL
because I sawon Clippy Documentation and these two lints are similar, so I think it might be good, not sure if it's right or not.
changelog:
NON_CANONICAL_CLONE_IMPL
,NON_CANONICAL_PARTIAL_ORD_IMPL
will skip proc marco now