Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let non_canonical_impls skip proc marco #12857

Merged
merged 2 commits into from
May 30, 2024

Conversation

WeiTheShinobi
Copy link
Contributor

@WeiTheShinobi WeiTheShinobi commented May 26, 2024

Fixed #12788

Although the issue only mentions NON_CANONICAL_CLONE_IMPL, this fix will also affect NON_CANONICAL_PARTIAL_ORD_IMPL because I saw

Because of these unforeseeable or unstable behaviors, macro expansion should often not be regarded as a part of the stable API.

on Clippy Documentation and these two lints are similar, so I think it might be good, not sure if it's right or not.


changelog: NON_CANONICAL_CLONE_IMPL, NON_CANONICAL_PARTIAL_ORD_IMPL will skip proc marco now

@rustbot
Copy link
Collaborator

rustbot commented May 26, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 26, 2024
@WeiTheShinobi WeiTheShinobi requested a review from y21 May 30, 2024 13:50
@WeiTheShinobi WeiTheShinobi marked this pull request as draft May 30, 2024 13:59
@WeiTheShinobi WeiTheShinobi marked this pull request as ready for review May 30, 2024 15:25
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go with this one fixed

tests/ui/non_canonical_clone_impl.stderr Outdated Show resolved Hide resolved
@WeiTheShinobi WeiTheShinobi force-pushed the non_canonical_impls branch 2 times, most recently from c88db48 to 38f173f Compare May 30, 2024 15:39
@y21
Copy link
Member

y21 commented May 30, 2024

Looks good, thanks! @bors r+

@bors
Copy link
Collaborator

bors commented May 30, 2024

📌 Commit 1038927 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 30, 2024

⌛ Testing commit 1038927 with merge e7efe43...

@bors
Copy link
Collaborator

bors commented May 30, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing e7efe43 to master...

@bors bors merged commit e7efe43 into rust-lang:master May 30, 2024
5 checks passed
@WeiTheShinobi WeiTheShinobi deleted the non_canonical_impls branch May 30, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non_canonical_clone_impl should skip proc macros
4 participants