Don't lint indexing_slicing lints on proc macros #12912
Merged
+80
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lochetti
force-pushed
the
fix_12824
branch
2 times, most recently
from
18c133d
to
1b667aa
Compare
dswij
reviewed
Jun 10, 2024
clippy_lints/src/indexing_slicing.rs
Outdated
| @@ -126,6 +126,10 @@ impl<'tcx> LateLintPass<'tcx> for IndexingSlicing { | |||
| return; | |||
| }; | |||
|
|
|||
| if is_from_proc_macro(cx, expr) { | |||
There was a problem hiding this comment.
Can we have this check earlier in check_expr?
There was a problem hiding this comment.
Yes, for sure! I thought that it would be better to postpone to the lastest moment, because this check is "heavy", but probably I misunderstood it :)
I will do the change!
There was a problem hiding this comment.
@dswij done. I have moved it to the very beginning of the function. Because of that, now we can have just one check instead of 4. Commit was amended.
dswij
approved these changes
Jun 11, 2024
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #12824
Even though the issue mentions the indexing case only, it was easy to apply the fix to the slicing case as well.
changelog: [
out_of_bounds_indexing,indexing_slicing]: Don't lint on procedural macros.