Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[missing_const_for_fn]: add machine-applicable suggestion #12930

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

DaniPopes
Copy link
Contributor

Add a machine-applicable suggestion to the missing_const_for_fn lint.

changelog: [missing_const_for_fn]: add machine-applicable suggestion

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 14, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Jun 23, 2024

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2024

📌 Commit 82f0dc9 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 23, 2024

⌛ Testing commit 82f0dc9 with merge 32374a1...

@bors
Copy link
Collaborator

bors commented Jun 23, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 32374a1 to master...

@bors bors merged commit 32374a1 into rust-lang:master Jun 23, 2024
5 checks passed
@DaniPopes DaniPopes deleted the missing-const-for-fn-suggestion branch June 23, 2024 20:56
@matthiaskrgr
Copy link
Member

Hmm this seems to clash a lot with other lints, like clippy suggests a fn to be const fn, at the same time, lints code inside the fn to be changed with something that is non-const and then cargo-clippy applies both of the suggestion at the same time and chaos ensues :/

@matthiaskrgr
Copy link
Member

Now that we can sift test for bugs via rustfix for this lint, this has also unearthed a bunch of FPs:

#13016
#13015
#13014
#13013
#13012
#13011
#13009
#13008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants