Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty_enum_variants_with_brackets: Do not lint pub enums and enums used as functions #12948

Closed
wants to merge 12 commits into from

Conversation

ARandomDev99
Copy link
Contributor

Fixes #12551

changelog: [empty_enum_variants_with_brackets]: Do not lint pub enums and enums which are used as functions within the same crate.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 17, 2024
@ARandomDev99
Copy link
Contributor Author

r? @xFrednet

@rustbot rustbot assigned xFrednet and unassigned Jarcho Jun 17, 2024
@xFrednet
Copy link
Member

Thank you for the reassign, you'll get a review from me soon. If you want to do some triaging on PRs that have been waiting for 2(+) weeks for a review you can also ping the reviewer or reassign them. r? clippy will pick a random reviewer but I also have some bandwidth, so r? xFrednet is fine :D

@xFrednet
Copy link
Member

This PR is still marked as a draft, is there something you're still waiting on?

@xFrednet
Copy link
Member

I'm high jacking this PR for a tiny test.

@bors ping

You can ignore this and (hopefully) the next comment

@bors
Copy link
Collaborator

bors commented Jun 18, 2024

😪 I'm awake I'm awake

@ARandomDev99
Copy link
Contributor Author

ARandomDev99 commented Jun 18, 2024

This PR is still marked as a draft, is there something you're still waiting on?

The implementation for checking if an enum variant is used as a function is still pending. I am working on it.

@xFrednet
Copy link
Member

Okay, no pressure from my side, just wanted to know the status. Let me know if you have any questions =^.^=

@ARandomDev99 ARandomDev99 deleted the issue-12551 branch June 21, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty_enum_variants_with_brackets is arguably not redundant
9 participants