Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrono compile-fail due to empty param_env #2786

Merged
merged 1 commit into from May 21, 2018
Merged

Fix chrono compile-fail due to empty param_env #2786

merged 1 commit into from May 21, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented May 21, 2018 •
edited

Looks like a simple fix and all tests still pass.

Fixes #2760

@phansch
Copy link
Member Author

phansch commented May 21, 2018 •
edited

Travis is not starting for some reason, even after a restart has a backlog of linux builds. The chrono integration tests should be running fine now. They didn't fail before, but the unsatisfied trait bound compile error should be gone now.

@phansch
Copy link
Member Author

phansch commented May 21, 2018

Running clippy on chrono works now: https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/381740798#L605-L617

@phansch phansch merged commit 736a1a8 into rust-lang:master May 21, 2018
@phansch phansch deleted the fix_param_env_compile_fail branch May 21, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo-clippy compile-errors on chrono 0.4.2
2 participants
@phansch @oli-obk