Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint using identity into_iter conversion #2975

Merged
merged 1 commit into from Aug 5, 2018

Conversation

Projects
None yet
3 participants
@aaudiber
Copy link
Contributor

commented Jul 30, 2018

This should address #2887.

I'd like to test further by running the lint against some existing codebases. Looking for guidance on how to run the Clippy I build locally against another local repo.

@matthiaskrgr

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2018

Hi, cd into the project you want to check, and then
path/to/clippy/repo/target/debug/cargo-clippy clippy might do the trick :)

@aaudiber

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2018

Tried it out in the rustfmt, rls, and rustfix repos, as well as rust-clippy itself, but didn't find any occurrences of using into_iter() on an iterator. If I introduce such an error, the warning does appear.

@phansch phansch merged commit 32e4897 into rust-lang:master Aug 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.