Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_unwrap to restriction #3863

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Move get_unwrap to restriction #3863

merged 1 commit into from
Mar 10, 2019

Conversation

Manishearth
Copy link
Member

fixes #3862

r? @oli-obk

@Manishearth
Copy link
Member Author

Haven't actually gotten a chance to test this

@@ -1,5 +1,6 @@
// run-rustfix
#![allow(unused_mut)]
#![deny(get_unwrap)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#![deny(get_unwrap)]
#![deny(clippy::get_unwrap)]

That should fix the test failure

@Manishearth
Copy link
Member Author

Fixed

@oli-obk
Copy link
Contributor

oli-obk commented Mar 10, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 10, 2019

📌 Commit 038ec7f has been approved by oli-obk

@bors
Copy link
Collaborator

bors commented Mar 10, 2019

⌛ Testing commit 038ec7f with merge 9308df7...

bors added a commit that referenced this pull request Mar 10, 2019
Move get_unwrap to restriction

fixes #3862

r? @oli-obk
@bors
Copy link
Collaborator

bors commented Mar 10, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 9308df7 to master...

@bors bors merged commit 038ec7f into master Mar 10, 2019
@flip1995 flip1995 deleted the get_unwrap branch October 28, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_unwrap is questionable advice
4 participants