Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow allowing of toplevel_ref_arg lint #4007

Merged
merged 1 commit into from Apr 20, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Apr 19, 2019

I'm not sure why some lints need the HirId to be able to recognize the
lint level attributes, but this commit makes the lint level attributes
work for toplevel_ref_arg.

Fixes #2332

changelog: Allow allowing of toplevel_ref_arg lint

I'm not sure why some lints need the `HirId` to be able to recognize the
lint level attributes, but this commit makes the lint level attributes
work for `toplevel_ref_arg`.
@flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 20, 2019

@bors r+

@bors
Copy link
Contributor

@bors bors commented Apr 20, 2019

📌 Commit 158aa39 has been approved by flip1995

@bors
Copy link
Contributor

@bors bors commented Apr 20, 2019

Testing commit 158aa39 with merge 54e80c7...

bors added a commit that referenced this issue Apr 20, 2019
Allow allowing of toplevel_ref_arg lint

I'm not sure why some lints need the `HirId` to be able to recognize the
lint level attributes, but this commit makes the lint level attributes
work for `toplevel_ref_arg`.

Fixes #2332

changelog: Allow allowing of `toplevel_ref_arg` lint
@bors
Copy link
Contributor

@bors bors commented Apr 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 54e80c7 to master...

@bors bors merged commit 158aa39 into rust-lang:master Apr 20, 2019
3 checks passed
@phansch phansch deleted the fix_allowing_toplevel_ref_arg branch Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants