Ignore non-const ctor expressions in or_fn_call #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fully general solution is to use a visitor and make sure that the Mind me filing a separate bug for this case so we can land this? |
oli-obk
approved these changes
Apr 23, 2019
|
@bors r+ |
|
📌 Commit 9a92e26 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 23, 2019
Ignore non-const ctor expressions in or_fn_call Fixes #1338 Should have been fixed by #919, however that focuses on const ctor expressions only, and `.or(Some(local))` isn't const. This also automatically ignores things like `.or(Some(local.clone())` which we don't actually want to do; I need to figure out what to do here. changelog: Fixed false positive in [`or_fn_call`] pertaining to enum variant constructors r? @oli-obk @phansch
|
💔 Test failed - checks-travis |
|
r=me with rustfmt applied |
Manishearth
force-pushed
the
or_fn_call_variants
branch
from
9a92e26
to
b03cf3f
Compare
|
@bors r=oli-obk ah, no wonder it wasn't getting formatted earlier, i'd forgotten |
|
📌 Commit b03cf3f has been approved by |
bors
added a commit
that referenced
this pull request
Apr 23, 2019
Ignore non-const ctor expressions in or_fn_call Fixes #1338 Should have been fixed by #919, however that focuses on const ctor expressions only, and `.or(Some(local))` isn't const. This also automatically ignores things like `.or(Some(local.clone())` which we don't actually want to do; I need to figure out what to do here. changelog: Fixed false positive in [`or_fn_call`] pertaining to enum variant constructors r? @oli-obk @phansch
|
💔 Test failed - status-appveyor |
|
needs rustup |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Apr 23, 2019
Ignore non-const ctor expressions in or_fn_call Fixes #1338 Should have been fixed by #919, however that focuses on const ctor expressions only, and `.or(Some(local))` isn't const. This also automatically ignores things like `.or(Some(local.clone())` which we don't actually want to do; I need to figure out what to do here. changelog: Fixed false positive in [`or_fn_call`] pertaining to enum variant constructors r? @oli-obk @phansch
|
The rust queue has a rollup waiting so might as well squeeze this in before I land the submodule update |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338
Should have been fixed by #919, however that focuses on const ctor expressions only, and
.or(Some(local))isn't const.This also automatically ignores things like
.or(Some(local.clone())which we don't actually want to do; I need to figure out what to do here.changelog: Fixed false positive in [
or_fn_call] pertaining to enum variant constructorsr? @oli-obk @phansch