Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useless_let_if_seq handle interior mutability #4035

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@JoshMcguigan
Copy link
Contributor

commented Apr 26, 2019

fixes #3043

This passes all tests, including a new one specifically dealing with a type with interior mutability. The main thing I'm unsure of is whether the span I used in the call to is_freeze is the most appropriate span to use, or if it matters.

JoshMcguigan added some commits Apr 26, 2019

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

@bors r+

thanks!

@bors

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

📌 Commit bb12d59 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

⌛️ Testing commit bb12d59 with merge 1cf5d7f...

bors added a commit that referenced this pull request May 2, 2019

Auto merge of #4035 - JoshMcguigan:useless_let_if_seq-3043, r=oli-obk
useless_let_if_seq handle interior mutability

fixes #3043

This passes all tests, including a new one specifically dealing with a type with interior mutability. The main thing I'm unsure of is whether the span I used in the call to `is_freeze` is the most appropriate span to use, or if it matters.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 1cf5d7f to master...

@bors bors merged commit bb12d59 into rust-lang:master May 2, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.