Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lints for find_map #4039

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@andrehjr
Copy link
Contributor

commented Apr 27, 2019

changelog: adds lints for find_map and filter_map_next. Closes issue #3474

Hope I got everything correctly this time! Let me know if I missed something.

@andrehjr andrehjr changed the title Add lints for find_map WIP: Add lints for find_map Apr 27, 2019

@andrehjr andrehjr marked this pull request as ready for review Apr 27, 2019

@andrehjr andrehjr force-pushed the andrehjr:add-find-map-lints branch from 2491c8d to f3f168e Apr 28, 2019

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

LGTM. Do you want to add anything else or can the "WIP" in the title be removed?

@andrehjr andrehjr changed the title WIP: Add lints for find_map Add lints for find_map Apr 30, 2019

@andrehjr andrehjr force-pushed the andrehjr:add-find-map-lints branch from ccdf8f0 to 2683884 Apr 30, 2019

@andrehjr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I removed the WIP, after the travis build finishes with success. Unless there are more comments it should be good to merge! Thanks! :)

Show resolved Hide resolved tests/ui/filter_map_next.rs Outdated
@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

I guess it's because the note gets to bloaty when the snippet is multiline. If this is done in other lints in this file, I agree that we should also do it here. But you can keep the test.

Thanks for trying this out!

@andrehjr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Awesome! just pushed the change bringing back the checks for multiliners

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

Thanks! If you squash these last few back and forth commits we can merge this :)

@andrehjr andrehjr force-pushed the andrehjr:add-find-map-lints branch from ca903ac to e428862 Apr 30, 2019

@andrehjr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Done @flip1995 rebased and squashed a few things 🚀

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

Perfect

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

📌 Commit e428862 has been approved by flip1995

bors added a commit that referenced this pull request Apr 30, 2019

Auto merge of #4039 - andrehjr:add-find-map-lints, r=flip1995
Add lints for find_map

changelog: adds lints for find_map and filter_map_next. Closes issue #3474

Hope I got everything correctly this time! Let me know if I missed something.
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

⌛️ Testing commit e428862 with merge e56e325...

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing e56e325 to master...

@bors bors merged commit e428862 into rust-lang:master Apr 30, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@bors bors referenced this pull request Apr 30, 2019

Merged

Implement "Use last" lint #3832

@andrehjr andrehjr deleted the andrehjr:add-find-map-lints branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.