Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .map(..).unwrap_or_else(..) bad suggestion #4164

Merged
merged 2 commits into from Jun 4, 2019
Merged

Fix .map(..).unwrap_or_else(..) bad suggestion #4164

merged 2 commits into from Jun 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2019

Closes #4144

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with NIT fixed

@bors delegate+

clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
Co-Authored-By: Philipp Krones <hello@philkrones.com>
@ghost
Copy link
Author

ghost commented Jun 4, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 4, 2019

📌 Commit 3b7d6ee has been approved by mikerite

@bors
Copy link
Collaborator

bors commented Jun 4, 2019

⌛ Testing commit 3b7d6ee with merge 42f96b2...

bors added a commit that referenced this pull request Jun 4, 2019
Fix .map(..).unwrap_or_else(..) bad suggestion

Closes #4144
@bors
Copy link
Collaborator

bors commented Jun 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: mikerite
Pushing 42f96b2 to master...

@bors bors merged commit 3b7d6ee into rust-lang:master Jun 4, 2019
@ghost ghost deleted the fix-4144 branch June 7, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy suggests: more directly with map_or_else(g, f) instead... recommendation does not compile
2 participants