Fix match_same_arms false negative
#4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should have a changelog entry in the PR body
…On Mon, Jul 1, 2019, 11:21 PM mikerite ***@***.***> wrote:
Closes #4244 <#4244>
changelog: none
------------------------------
You can view, comment on, or merge this pull request online at:
#4246
Commit Summary
- Fix `match_same_arms` false negative
File Changes
- *M* clippy_lints/src/copies.rs
<https://github.com/rust-lang/rust-clippy/pull/4246/files#diff-0> (20)
- *M* tests/ui/match_same_arms.rs
<https://github.com/rust-lang/rust-clippy/pull/4246/files#diff-1> (19)
- *M* tests/ui/match_same_arms.stderr
<https://github.com/rust-lang/rust-clippy/pull/4246/files#diff-2> (19)
Patch Links:
- https://github.com/rust-lang/rust-clippy/pull/4246.patch
- https://github.com/rust-lang/rust-clippy/pull/4246.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4246?email_source=notifications&email_token=AAMK6SBG7COUQNY74VRF4LDP5LXVHA5CNFSM4H4YMOP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4ZOY4Q>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMK6SBJIZL5NOXHRRTBPQ3P5LXVHANCNFSM4H4YMOPQ>
.
|
|
Updated the comment. I hope that suffices. |
|
Thanks! @bors r+ |
|
📌 Commit c199d90 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 2, 2019
Fix `match_same_arms` false negative Closes #4244 changelog: Fix `match_same_arms` false negative
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4244
changelog: Fix
match_same_armsfalse negative