Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the use_self lint to suggest uses of Self::Variant #4308

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Extend the use_self lint to suggest uses of Self::Variant #4308

merged 2 commits into from
Jul 31, 2019

Conversation

jakubadamw
Copy link
Contributor

Fixes #4296.

changelog: Extend the use_self lint to suggest uses of Self::Variant

flip1995
flip1995 requested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, 2 small style issues I had

clippy_lints/src/use_self.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 mentioned this pull request Jul 31, 2019
Open
@jakubadamw
Extend the use_self lint to suggest uses of Self::Variant.
41110b0
@jakubadamw
Update all the code to pass the updated use_self lint.
2a13e83 
One struct required a temporary `#[allow(dead_code)]` annotation due to
a bug in the Rust compiler: rust-lang/rust#63151.
@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 31, 2019
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 31, 2019

📌 Commit 2a13e83 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jul 31, 2019

⌛ Testing commit 2a13e83 with merge 128647d...

bors added a commit that referenced this pull request Jul 31, 2019
@bors
Auto merge of #4308 - jakubadamw:use-self-variant-scope, r=flip1995
128647d 
Extend the `use_self` lint to suggest uses of `Self::Variant`

Fixes #4296.

changelog: Extend the `use_self` lint to suggest uses of `Self::Variant`
@bors
Copy link
Collaborator

bors commented Jul 31, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 128647d to master...

@bors bors merged commit 2a13e83 into rust-lang:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New lint: Suggest using Self::Variant instead of TheType::Variant
3 participants
@jakubadamw @flip1995 @bors