Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused_collect lint #4348

Merged
merged 1 commit into from Aug 15, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Aug 7, 2019

I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

Playground Examples

changelog: Deprecate unused_collect lint. This is fully covered by rustc's #[must_use] on collect

cc #2846

tests/ui/deprecated.stderr Outdated Show resolved Hide resolved
@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Aug 7, 2019
@phansch phansch force-pushed the deprecate-unused-unused-collect branch from 6fd72cb to beadfd4 Compare August 7, 2019 06:04
@phansch phansch removed the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Aug 7, 2019
@phansch phansch force-pushed the deprecate-unused-unused-collect branch from beadfd4 to 2aa71a8 Compare August 7, 2019 06:08
@phansch phansch added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Aug 7, 2019
@phansch
Copy link
Member Author

phansch commented Aug 7, 2019

Blocking this on #4349

@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Aug 7, 2019
@bors
Copy link
Collaborator

bors commented Aug 11, 2019

☔ The latest upstream changes (presumably #4368) made this pull request unmergeable. Please resolve the merge conflicts.

@phansch phansch removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Aug 14, 2019
@phansch phansch force-pushed the deprecate-unused-unused-collect branch from 2aa71a8 to ed1f384 Compare August 14, 2019 17:10
I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

[Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4)

changelog: Deprecate `unused_collect` lint. This is fully covered by
rustc's `#[must_use]` on `collect`

cc rust-lang#2846
@phansch phansch force-pushed the deprecate-unused-unused-collect branch from ed1f384 to 42f0353 Compare August 14, 2019 19:48
@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 14, 2019
@flip1995
Copy link
Member

That should be ready now.

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2019

📌 Commit 42f0353 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 15, 2019

⌛ Testing commit 42f0353 with merge a3da66d...

bors added a commit that referenced this pull request Aug 15, 2019
…1995

Deprecate unused_collect lint

I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

[Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4)

changelog: Deprecate `unused_collect` lint. This is fully covered by rustc's `#[must_use]` on `collect`

cc #2846
@bors
Copy link
Collaborator

bors commented Aug 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a3da66d to master...

@bors bors merged commit 42f0353 into rust-lang:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants