Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused_collect lint #4348

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@phansch
Copy link
Member

commented Aug 7, 2019

I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

Playground Examples

changelog: Deprecate unused_collect lint. This is fully covered by rustc's #[must_use] on collect

cc #2846

tests/ui/deprecated.stderr Outdated Show resolved Hide resolved

@phansch phansch force-pushed the phansch:deprecate-unused-unused-collect branch from 6fd72cb to beadfd4 Aug 7, 2019

@phansch phansch force-pushed the phansch:deprecate-unused-unused-collect branch from beadfd4 to 2aa71a8 Aug 7, 2019

@phansch phansch added the S-blocked label Aug 7, 2019

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Blocking this on #4349

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

☔️ The latest upstream changes (presumably #4368) made this pull request unmergeable. Please resolve the merge conflicts.

@phansch phansch removed the S-blocked label Aug 14, 2019

@phansch phansch force-pushed the phansch:deprecate-unused-unused-collect branch from 2aa71a8 to ed1f384 Aug 14, 2019

Deprecate unused_collect lint
I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

[Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4)

changelog: Deprecate `unused_collect` lint. This is fully covered by
rustc's `#[must_use]` on `collect`

cc #2846

@phansch phansch force-pushed the phansch:deprecate-unused-unused-collect branch from ed1f384 to 42f0353 Aug 14, 2019

@flip1995

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

That should be ready now.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

📌 Commit 42f0353 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

⌛️ Testing commit 42f0353 with merge a3da66d...

bors added a commit that referenced this pull request Aug 15, 2019
Auto merge of #4348 - phansch:deprecate-unused-unused-collect, r=flip…
…1995

Deprecate unused_collect lint

I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

[Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4)

changelog: Deprecate `unused_collect` lint. This is fully covered by rustc's `#[must_use]` on `collect`

cc #2846
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a3da66d to master...

@bors bors merged commit 42f0353 into rust-lang:master Aug 15, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.