Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused_collect lint #4348

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 7, 2019

I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

Playground Examples

changelog: Deprecate unused_collect lint. This is fully covered by rustc's #[must_use] on collect

cc #2846

tests/ui/deprecated.stderr Outdated Show resolved Hide resolved
Loading
@phansch
Copy link
Member Author

@phansch phansch commented Aug 7, 2019

Blocking this on #4349

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 11, 2019

The latest upstream changes (presumably #4368) made this pull request unmergeable. Please resolve the merge conflicts.

Loading

@phansch phansch removed the S-blocked label Aug 14, 2019
@phansch phansch force-pushed the deprecate-unused-unused-collect branch from 2aa71a8 to ed1f384 Aug 14, 2019
I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

[Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4)

changelog: Deprecate `unused_collect` lint. This is fully covered by
rustc's `#[must_use]` on `collect`

cc rust-lang#2846
@phansch phansch force-pushed the deprecate-unused-unused-collect branch from ed1f384 to 42f0353 Aug 14, 2019
@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 15, 2019

That should be ready now.

@bors r+

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 15, 2019

📌 Commit 42f0353 has been approved by flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 15, 2019

Testing commit 42f0353 with merge a3da66d...

Loading

bors added a commit that referenced this issue Aug 15, 2019
…1995

Deprecate unused_collect lint

I found this because we only had two test cases in total for this lint.
It turns out the functionality is fully covered by rustc these days.

[Playground Examples](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=eb8ee6db389c77180c9fb152d3c608f4)

changelog: Deprecate `unused_collect` lint. This is fully covered by rustc's `#[must_use]` on `collect`

cc #2846
@bors
Copy link
Contributor

@bors bors commented Aug 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a3da66d to master...

Loading

@bors bors merged commit 42f0353 into rust-lang:master Aug 15, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants