new_ret_no_self: allow Self in inner type for impl Trait return types #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Aug 9, 2019
tests/ui/methods.rs
Outdated
| struct AsyncNew; | ||
|
|
||
| impl AsyncNew { | ||
| fn new() -> impl Future<Output = Option<Self>> { |
There was a problem hiding this comment.
Why not just make this function async and use the async_await feature in this test?
Everything else LGTM.
There was a problem hiding this comment.
Because the tests seem to use Rust 2015 (which does not have async fns) and I don't know how to change that.
There was a problem hiding this comment.
Ah, this again 😄
You have to add
rust-clippy/tests/ui/issue_4266.rs
Lines 1 to 2 in d71e9c4
at the top of the test case. We should document this.
flip1995
reviewed
Aug 9, 2019
tests/ui/methods.rs
Outdated
| @@ -23,10 +25,13 @@ use std::collections::BTreeMap; | |||
| use std::collections::HashMap; | |||
| use std::collections::HashSet; | |||
| use std::collections::VecDeque; | |||
| use std::future::Future; | |||
added 3 commits
August 9, 2019 19:44
|
Thanks! @bors r+ |
|
📌 Commit d553158 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 11, 2019
new_ret_no_self: allow Self in inner type for impl Trait return types
Check the inner types of associated types of a trait when checking for Self in the return type of a `new` method. This means that the following will no longer warn:
```rust
trait Trait {
type Inner;
}
struct S;
impl S {
fn new() -> impl Trait<Inner = Option<Self>> {
struct TraitImpl;
impl Trait for TraitImpl {
type Inner = Option<S>;
}
TraitImpl
}
}
```
```rust
#![feature(async_await)]
struct Connection;
impl Connection {
async fn new() -> Result<Self, ()> {
Ok(S)
}
}
```
closes #4359
|
💔 Test failed - checks-travis |
|
Forgot the changelog @bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit d553158 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 11, 2019
new_ret_no_self: allow Self in inner type for impl Trait return types
Check the inner types of associated types of a trait when checking for Self in the return type of a `new` method. This means that the following will no longer warn:
```rust
trait Trait {
type Inner;
}
struct S;
impl S {
fn new() -> impl Trait<Inner = Option<Self>> {
struct TraitImpl;
impl Trait for TraitImpl {
type Inner = Option<S>;
}
TraitImpl
}
}
```
```rust
#![feature(async_await)]
struct Connection;
impl Connection {
async fn new() -> Result<Self, ()> {
Ok(S)
}
}
```
closes #4359
changelog: fix `new_ret_no_self` lint for async `new` functions.
|
💔 Test failed - checks-travis |
bors
added a commit
that referenced
this pull request
Aug 12, 2019
Document how to write tests requiring the 2018 edition [Rendered](https://github.com/flip1995/rust-clippy/blob/doc_edition_2018_tests/doc/adding_lints.md#Edition-2018-tests) cc #4365 changelog: none
|
@bors retry |
bors
added a commit
that referenced
this pull request
Aug 12, 2019
new_ret_no_self: allow Self in inner type for impl Trait return types
Check the inner types of associated types of a trait when checking for Self in the return type of a `new` method. This means that the following will no longer warn:
```rust
trait Trait {
type Inner;
}
struct S;
impl S {
fn new() -> impl Trait<Inner = Option<Self>> {
struct TraitImpl;
impl Trait for TraitImpl {
type Inner = Option<S>;
}
TraitImpl
}
}
```
```rust
#![feature(async_await)]
struct Connection;
impl Connection {
async fn new() -> Result<Self, ()> {
Ok(S)
}
}
```
closes #4359
changelog: fix `new_ret_no_self` lint for async `new` functions.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the inner types of associated types of a trait when checking for Self in the return type of a
newmethod. This means that the following will no longer warn:closes #4359
changelog: fix
new_ret_no_selflint for asyncnewfunctions.