Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong_self_convention issue #4369

Merged
merged 3 commits into from Aug 14, 2019
Merged

Fix wrong_self_convention issue #4369

merged 3 commits into from Aug 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2019

Resolves #4293

changelog: Fix wrong_self_convention issue

Michael Wright added 3 commits August 10, 2019 05:58
`impl_item` is proper snake case and used everywhere else.
Use actual types instead of hir types.
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 12, 2019
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2019

📌 Commit 77278cc has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 14, 2019

⌛ Testing commit 77278cc with merge 63d2d06...

bors added a commit that referenced this pull request Aug 14, 2019
 Fix `wrong_self_convention` issue

Resolves #4293

changelog: Fix `wrong_self_convention` issue
@bors
Copy link
Collaborator

bors commented Aug 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 63d2d06 to master...

@bors bors merged commit 77278cc into rust-lang:master Aug 14, 2019
@ghost ghost deleted the fix-4293 branch August 15, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should wrong_self_convention apply to self: Box<Self>, self: Rc<Self> and self: Arc<Self>?
3 participants